Skip to content

Fix magnetometer#334

Merged
nitin710 merged 2 commits intodevfrom
fix-Magnetometer
Sep 11, 2025
Merged

Fix magnetometer#334
nitin710 merged 2 commits intodevfrom
fix-Magnetometer

Conversation

@Joseph-Jacobson
Copy link
Contributor

@Joseph-Jacobson Joseph-Jacobson commented Aug 11, 2025 •
edited
Loading

Description

Fixed magnetometer units from microhenries to microteslas as per this issue .

Requirements

  • Xplat Splitter Refactor #30

Issues Referenced

Documentation update

None

Notes for Reviewer

  • Minor change to rename the magnetometer unit.

Testing

✔️ info.json now says microteslas

Bug: microhenries

2025-08-05_08-39-12-408267_info.json

Fix: microteslas

2025-08-11_08-30-12-081385_info.json

Feature Tests (Integration tests)

Feature Test Result
Info.file unit - microteslas ✔️

Unit Tests

None

Shared files

  • Firmware binary: [Link to firmware binary]
  • Other files.

List of new distributable files (For software PR only)

  • Name all new files added with this PR that need to be distributed with the release package. This includes files like .json, .xml settings files etc.

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Get approval from the reviewer
    • Passed testing on Windows
    • Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Update software bundle version in ofxEmotiBitVersion.h
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • doxygen style comments included for new code snippets
  • Required documentation updated

Screenshots:

@Joseph-Jacobson Joseph-Jacobson changed the base branch from master to dev August 11, 2025 15:39
@Joseph-Jacobson Joseph-Jacobson marked this pull request as ready for review August 11, 2025 15:45
@nitin710
Merge branch 'dev' into fix-Magnetometer
4109175 
pulling latest dev into fix-magnetometer
@coderabbitai
Copy link

coderabbitai bot commented Sep 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-Magnetometer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitin710 nitin710 merged commit 0c14080 into dev Sep 11, 2025
2 checks passed
@nitin710 nitin710 deleted the fix-Magnetometer branch September 11, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitin710 nitin710 Awaiting requested review from nitin710

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Magnetometer units in info.json file needs to be updated to uT

2 participants

@Joseph-Jacobson @nitin710

Comments